etseidl commented on code in PR #449:
URL: https://github.com/apache/parquet-format/pull/449#discussion_r1724433465
##########
src/main/thrift/parquet.thrift:
##########
@@ -257,7 +257,14 @@ struct Statistics {
*/
1: optional binary max;
2: optional binary min;
- /** count of null value in the column */
+ /**
+ * count of null value in the column
Review Comment:
```suggestion
* Count of null values in the column.
```
##########
src/main/thrift/parquet.thrift:
##########
@@ -257,7 +257,14 @@ struct Statistics {
*/
1: optional binary max;
2: optional binary min;
- /** count of null value in the column */
+ /**
+ * count of null value in the column
+ *
+ * Writers SHOULD always write this field even if it is zero (a.k.a. no
null value)
Review Comment:
```suggestion
* Writers SHOULD always write this field even if it is zero (i.e. no
null value)
```
##########
src/main/thrift/parquet.thrift:
##########
@@ -257,7 +257,14 @@ struct Statistics {
*/
1: optional binary max;
2: optional binary min;
- /** count of null value in the column */
+ /**
+ * count of null value in the column
+ *
+ * Writers SHOULD always write this field even if it is zero (a.k.a. no
null value)
+ * or is an not nullable column.
+ * Readers SHOULD distinct null_count == 0 or not having null_count. If
null_count
+ * doesn't exists, Readers cannot gurantees null_count == 0.
Review Comment:
```suggestion
* Readers SHOULD distinguish between null_count not being present and
null_count == 0.
* If null_count is not present, readers SHOULD NOT assume null_count ==
0.
```
##########
src/main/thrift/parquet.thrift:
##########
@@ -257,7 +257,14 @@ struct Statistics {
*/
1: optional binary max;
2: optional binary min;
- /** count of null value in the column */
+ /**
+ * count of null value in the column
+ *
+ * Writers SHOULD always write this field even if it is zero (a.k.a. no
null value)
+ * or is an not nullable column.
Review Comment:
```suggestion
* or the column is not nullable.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
