pitrou commented on code in PR #449:
URL: https://github.com/apache/parquet-format/pull/449#discussion_r1725062774
##########
src/main/thrift/parquet.thrift:
##########
@@ -1084,7 +1091,16 @@ struct ColumnIndex {
*/
4: required BoundaryOrder boundary_order
- /** A list containing the number of null values for each page **/
+ /**
+ * A list containing the number of null values for each page
+ *
+ * Writers SHOULD always write this field even if no null value
+ * or the column is not nullable.
+ * Readers MUST distinguish between null_counts not being present
+ * and null_count is 0.
Review Comment:
```suggestion
* and null_count being 0.
```
##########
src/main/thrift/parquet.thrift:
##########
@@ -1084,7 +1091,16 @@ struct ColumnIndex {
*/
4: required BoundaryOrder boundary_order
- /** A list containing the number of null values for each page **/
+ /**
+ * A list containing the number of null values for each page
+ *
+ * Writers SHOULD always write this field even if no null value
+ * or the column is not nullable.
+ * Readers MUST distinguish between null_counts not being present
+ * and null_count is 0.
+ * If null_counts is not present, readers MUST NOT assume all
+ * null_count is 0.
Review Comment:
```suggestion
* null counts are 0.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
