gszadovszky commented on PR #449: URL: https://github.com/apache/parquet-format/pull/449#issuecomment-2301283092
@mapleFU, it looks good to me and is a proper change for the actual case. However, the statement `If null_count is not present, readers SHOULD NOT assume null_count == 0.` should be a general one for each optional values in this file. We've had a couple of issues not checking whether a field is actually set and using its default value. Maybe `SHOULD` would be better being a `MUST`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
