wgtmac commented on code in PR #466:
URL: https://github.com/apache/parquet-format/pull/466#discussion_r1821868722
##########
LogicalTypes.md:
##########
@@ -654,13 +654,18 @@ should always be determined by the following rules:
1. If the repeated field is not a group, then its type is the element type and
elements are required.
-2. If the repeated field is a group with multiple fields, then its type is the
- element type and elements are required.
-3. If the repeated field is a group with one field and is named either `array`
- or uses the `LIST`-annotated group's name with `_tuple` appended then the
- repeated type is the element type and elements are required.
+2. If the repeated field is a group (without `LIST` or `MAP` annotation) with
+ multiple fields, then its type (i.e. a multi-field Tuple) is the element
+ type and elements are required.
+3. If the repeated field is a group (without `LIST` or `MAP` annotation) with
+ one field (with `required` or `optional` repetition) and is named either
+ `array` or uses the `LIST`-annotated group's name with `_tuple` appended,
+ then the repeated type is the element type and elements are required. Note
+ that the element type resolves to a single-field Tuple type.
4. Otherwise, the repeated field's type is the element type with the repeated
- field's repetition.
+ field's repetition and elements are required. Note that the element type
+ resolves to List or Map type if the repeated field is `LIST`-annotated or
+ `MAP`-annotated; otherwise the element type resolves to a Tuple type.
Review Comment:
The example below uses `Tuple` and `OneTuple` and we'd better be consistent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
