wgtmac commented on code in PR #466:
URL: https://github.com/apache/parquet-format/pull/466#discussion_r1822227723
##########
LogicalTypes.md:
##########
@@ -654,12 +654,15 @@ should always be determined by the following rules:
1. If the repeated field is not a group, then its type is the element type and
elements are required.
-2. If the repeated field is a group with multiple fields, then its type is the
+2. If the repeated field is a group with `LIST` or `MAP` annotation, then the
Review Comment:
```
1. If the repeated field is not a group, then its type is the element type
and
elements are required.
2. If the repeated field is a group with multiple fields, then its type is
the
element type and elements are required. To be clear, if the group does not
have annotation, the element type resolves to a multi-field Tuple. If the
group is `LIST`-annotated or `MAP`-annotated, it should resolve to List or
Map type, respectively.
3. If the repeated field is a group (without annotation) with one `required`
or
`optional` field, and is named either `array` or uses the `LIST`-annotated
group's name with `_tuple` appended, then the repeated type (a
single-field
Tuple type) is the element type and elements are required.
4. Otherwise, the repeated field's type is the element type with the repeated
field's repetition.
```
This is another version I've come up with, which implicitly applies
`repeated field is a group with LIST or MAP annotation` to the last rule
`Otherwise, the repeated field's type is the element type with the repeated
field's repetition.`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
