wgtmac commented on code in PR #3559:
URL: https://github.com/apache/parquet-java/pull/3559#discussion_r3231745416
##########
parquet-common/src/main/java/org/apache/parquet/bytes/TrackingByteBufferAllocator.java:
##########
@@ -154,12 +171,12 @@ public boolean isDirect() {
}
@Override
- public void close() throws LeakedByteBufferException {
- if (!allocated.isEmpty()) {
- LeakedByteBufferException ex = new LeakedByteBufferException(
Review Comment:
This looks like a behavior change?
##########
pom.xml:
##########
@@ -83,7 +83,7 @@
<spotless.version>2.46.1</spotless.version>
<shade.prefix>shaded.parquet</shade.prefix>
<!-- Guarantees no newer classes/methods/constants are used by parquet. -->
- <hadoop.version>3.3.0</hadoop.version>
+ <hadoop.version>3.4.0</hadoop.version>
Review Comment:
Do we want to reflect this in the PR title?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
