Fokko commented on code in PR #3559:
URL: https://github.com/apache/parquet-java/pull/3559#discussion_r3232172878
##########
parquet-common/src/main/java/org/apache/parquet/bytes/TrackingByteBufferAllocator.java:
##########
@@ -154,12 +171,12 @@ public boolean isDirect() {
}
@Override
- public void close() throws LeakedByteBufferException {
- if (!allocated.isEmpty()) {
- LeakedByteBufferException ex = new LeakedByteBufferException(
Review Comment:
I don't think this was working properly since Hadoop did raise exception
around not properly closing buffers, while this exception wasn't being thrown.
Let me dig a bit further here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
