gszadovszky commented on code in PR #3559:
URL: https://github.com/apache/parquet-java/pull/3559#discussion_r3232440759
##########
parquet-common/src/main/java/org/apache/parquet/bytes/TrackingByteBufferAllocator.java:
##########
@@ -154,12 +171,12 @@ public boolean isDirect() {
}
@Override
- public void close() throws LeakedByteBufferException {
- if (!allocated.isEmpty()) {
- LeakedByteBufferException ex = new LeakedByteBufferException(
Review Comment:
Yeah. The whole point of this allocator implementation is to fail if
something was not released. It may make sense to actually release the buffers
so the tests won't leak, be we need to throw that exception, otherwise this
class is pointless.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
