yadavay-amzn commented on PR #3556: URL: https://github.com/apache/parquet-java/pull/3556#issuecomment-4619132951
Thanks for taking a look @wgtmac ! I like the idea of having a threshold on the raw data to delay the compression check. Updated the check in `FallbackValuesWriter.getBytes()` to only fire if rawDataByteSize >= threshold (defaulting to 1MB). I think the page count approach (checking after N pages) is sensitive to page size configurations. So with 1KB pages you'd need many pages to accumulate meaningful data, while with 1MB pages a single page might be enough. A byte threshold adapts naturally regardless of page size settings. That being said I'd like to know which approach you'd prefer and iterate based on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
