yadavay-amzn commented on PR #3556:
URL: https://github.com/apache/parquet-java/pull/3556#issuecomment-4634123313
@wgtmac Addressed all comments:
- Renamed config to `parquet.dictionary.check.threshold.raw.size.bytes`
- Performance: accumulate `cumulativeRawBytes` once per page (in
`getBytes()`) instead of per value
- Added multi-page test proving threshold is crossed after `reset()`
- Javadoc fixed ("0 = check on first page")
- Negative value validation added
- Applied code suggestions (named arg comments, field grouping, Javadoc on
cumulativeRawBytes)
- Rebased on master (clean 7-file diff now)
Thanks for the thorough review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
