yadavay-amzn commented on code in PR #3556:
URL: https://github.com/apache/parquet-java/pull/3556#discussion_r3376601056
##########
parquet-column/src/main/java/org/apache/parquet/column/values/fallback/FallbackValuesWriter.java:
##########
@@ -30,7 +30,12 @@ public class FallbackValuesWriter<I extends ValuesWriter &
RequiresFallback, F e
public static <I extends ValuesWriter & RequiresFallback, F extends
ValuesWriter> FallbackValuesWriter<I, F> of(
I initialWriter, F fallBackWriter) {
- return new FallbackValuesWriter<>(initialWriter, fallBackWriter);
+ return new FallbackValuesWriter<>(initialWriter, fallBackWriter,
/*checkAfterBytes=*/ 0);
+ }
+
+ public static <I extends ValuesWriter & RequiresFallback, F extends
ValuesWriter> FallbackValuesWriter<I, F> of(
+ I initialWriter, F fallBackWriter, long checkAfterBytes) {
Review Comment:
Renamed `checkAfterBytes` to `dictionaryCheckThresholdRawSizeBytes`
throughout
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
