Fokko commented on code in PR #574:
URL: https://github.com/apache/parquet-format/pull/574#discussion_r3360603369
##########
VariantEncoding.md:
##########
@@ -367,9 +370,9 @@ primitive_val: see table for binary representation
short_string_val: UTF-8 encoded bytes
object_val: <num_elements> <field_id>* <field_offset>* <fields>
array_val: <num_elements> <field_offset>* <fields>
-num_elements: a 1 or 4 byte unsigned little-endian value (depending on
is_large in <object_header>/<array_header>)
-field_id: a 1, 2, 3 or 4 byte unsigned little-endian value (depending on
field_id_size_minus_one in <object_header>), indexing into the dictionary
-field_offset: a 1, 2, 3 or 4 byte unsigned little-endian value (depending on
field_offset_size_minus_one in <object_header>/<array_header>), providing the
offset in bytes within fields
+num_elements: a 1- or 4-byte unsigned little-endian value (depending on
is_large in <object_header>/<array_header>)
Review Comment:
This way of using dashes is _very_ common in the Dutch language to indicate
that 1 also relates to byte :)
##########
VariantShredding.md:
##########
@@ -294,7 +294,7 @@ def construct_variant(metadata: Metadata, value: Variant,
typed_value: Any) -> V
# this is a shredded object
object_fields = {
name: construct_variant(metadata, field.value,
field.typed_value)
- for (name, field) in typed_value
+ for (name, field) in typed_value.items()
Review Comment:
Yes, the `.items()` is required here. Since less is more, we can drop the
parentheses while at it:
```suggestion
for name, field in typed_value.items()
```
##########
VariantShredding.md:
##########
@@ -85,8 +85,8 @@ Shredded values must use the following Parquet types:
| Variant Type | Parquet Physical Type | Parquet
Logical Type |
|-----------------------------|-----------------------------------|--------------------------|
| boolean | BOOLEAN |
|
-| int8 | INT32 | INT(8,
signed=true) |
-| int16 | INT32 | INT(16,
signed=true) |
+| int8 | INT32 | INT(8,
true) |
Review Comment:
I have the same, also for the table in VariantEncoding.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
