iemejia commented on code in PR #574:
URL: https://github.com/apache/parquet-format/pull/574#discussion_r3363055379
##########
VariantShredding.md:
##########
@@ -294,7 +294,7 @@ def construct_variant(metadata: Metadata, value: Variant,
typed_value: Any) -> V
# this is a shredded object
object_fields = {
name: construct_variant(metadata, field.value,
field.typed_value)
- for (name, field) in typed_value
+ for (name, field) in typed_value.items()
Review Comment:
Done. Dropped the redundant parentheses as suggested.
##########
VariantShredding.md:
##########
@@ -85,8 +85,8 @@ Shredded values must use the following Parquet types:
| Variant Type | Parquet Physical Type | Parquet
Logical Type |
|-----------------------------|-----------------------------------|--------------------------|
| boolean | BOOLEAN |
|
-| int8 | INT32 | INT(8,
signed=true) |
-| int16 | INT32 | INT(16,
signed=true) |
+| int8 | INT32 | INT(8,
true) |
Review Comment:
Keeping `INT(8, true)` here for consistency — this is the canonical notation
used across the specification: `LogicalTypes.md` defines and uses it
extensively (lines 100, 109, 110, 123, 132, 133), and the equivalent table in
`VariantEncoding.md` also uses `INT(8, true)`, `INT(16, true)`, `INT(32,
true)`, `INT(64, true)`. Having one table use a different notation would be the
odd one out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
