iemejia commented on code in PR #574: URL: https://github.com/apache/parquet-format/pull/574#discussion_r3386916929
########## VariantEncoding.md: ########## @@ -87,6 +87,7 @@ The `version` is a 4-bit value that must always contain the value `1`. `sorted_strings` is a 1-bit value indicating whether dictionary strings are sorted and unique. `offset_size_minus_one` is a 2-bit value providing the number of bytes per dictionary size and offset field. The actual number of bytes, `offset_size`, is `offset_size_minus_one + 1`. +Bit 5 (marked `R`) is reserved; it must be set to 0 by writers and ignored by readers. Review Comment: You're right. I've reverted the writer mandate — the reserved bits now only say "must be ignored by readers" without prescribing writer behavior. If we want to add the writer constraint later, we can bring it to the mailing list. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
