rdblue commented on code in PR #3610:
URL: https://github.com/apache/parquet-java/pull/3610#discussion_r3397683375
##########
parquet-column/src/main/java/org/apache/parquet/schema/ColumnOrder.java:
##########
@@ -36,11 +36,18 @@ public enum ColumnOrderName {
/**
* Type defined order meaning that the comparison order of the elements
are based on its type.
*/
- TYPE_DEFINED_ORDER
+ TYPE_DEFINED_ORDER,
+ /**
+ * Chronological order for INT96 timestamps: values are compared by the
Julian day (the last 4
+ * bytes, as a little-endian signed int32), then by the nanoseconds within
the day (the first 8
+ * bytes, as a little-endian signed int64). Only supported for the INT96
physical type.
Review Comment:
I don't think that this Javadoc is the right place for documenting the
format and how to compare. This is part of the spec so the spec needs to be
clear and this needs to state what the order means.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
