rdblue commented on code in PR #3610:
URL: https://github.com/apache/parquet-java/pull/3610#discussion_r3397738701
##########
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/InternalParquetRecordWriter.java:
##########
@@ -89,7 +89,7 @@ public InternalParquetRecordWriter(
ParquetProperties props) {
this.parquetFileWriter = parquetFileWriter;
this.writeSupport = Objects.requireNonNull(writeSupport, "writeSupport
cannot be null");
- this.schema = schema;
+ this.schema = ParquetFileWriter.applyInt96TimestampOrder(schema, props);
Review Comment:
I don't think this is the right place to fixup order. It would be better to
always use the new order for INT96 when constructing schemas. When converting
from file schemas, we would need to detect timestamp vs unordered, but anything
going through the write path should automatically use timestamp order because
the write path should always produce it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
