divjotarora commented on code in PR #3610:
URL: https://github.com/apache/parquet-java/pull/3610#discussion_r3413451226
##########
parquet-column/src/main/java/org/apache/parquet/schema/PrimitiveComparator.java:
##########
@@ -293,4 +294,36 @@ public String toString() {
return "BINARY_AS_FLOAT16_COMPARATOR";
}
};
+
+ /*
Review Comment:
I was copying the formatting from
[BINARY_AS_SIGNED_INTEGER_COMPARATOR](https://github.com/apache/parquet-java/blob/65884b558785da1c05f9398a83a12390e3b2d7f5/parquet-column/src/main/java/org/apache/parquet/schema/PrimitiveComparator.java#L209).
Is this not the right way
##########
parquet-column/src/main/java/org/apache/parquet/schema/PrimitiveComparator.java:
##########
@@ -293,4 +294,36 @@ public String toString() {
return "BINARY_AS_FLOAT16_COMPARATOR";
}
};
+
+ /*
Review Comment:
I was copying the formatting from
[BINARY_AS_SIGNED_INTEGER_COMPARATOR](https://github.com/apache/parquet-java/blob/65884b558785da1c05f9398a83a12390e3b2d7f5/parquet-column/src/main/java/org/apache/parquet/schema/PrimitiveComparator.java#L209).
Is this not the right way?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
