divjotarora commented on code in PR #3610:
URL: https://github.com/apache/parquet-java/pull/3610#discussion_r3415941297


##########
parquet-column/src/main/java/org/apache/parquet/schema/PrimitiveType.java:
##########
@@ -655,6 +661,15 @@ public PrimitiveType 
withLogicalTypeAnnotation(LogicalTypeAnnotation logicalType
     return new PrimitiveType(getRepetition(), primitive, length, getName(), 
logicalType, getId());
   }
 
+  /**
+   * @param columnOrder the column order
+   * @return a new PrimitiveType with the same fields and the given column 
order
+   */
+  public PrimitiveType withColumnOrder(ColumnOrder columnOrder) {

Review Comment:
   Removed the writer-side flag and all of this schema-fixing code.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to