peter-toth commented on code in PR #3597:
URL: https://github.com/apache/parquet-java/pull/3597#discussion_r3499802980
##########
parquet-column/src/main/java/org/apache/parquet/filter2/columnindex/RowRanges.java:
##########
@@ -316,4 +316,72 @@ public List<Range> getRanges() {
public String toString() {
return ranges.toString();
}
+
+ /**
Review Comment:
Ok, moved in
https://github.com/apache/parquet-java/pull/3597/commits/8d8e2dd71d51a639cd61f27b9e340b3937bc3f51.
One thing to flag: the relocation changes a public signature
`ParquetFileReader.readFilteredRowGroup(int, RowRanges)` now takes the new
public `RowRanges` instead of the internal one. japicmp reports this as
`METHOD_REMOVED` (and the inherited form on
`CompressionConverter$TransParquetFileReader`), so I added excludes for:
- `org.apache.parquet.internal.filter2.columnindex.RowRanges` (+ `$Range`)
- `org.apache.parquet.internal.filter2.columnindex.ColumnIndexFilter`
(return-type changes)
- `org.apache.parquet.hadoop.ParquetFileReader#readFilteredRowGroup(int,
…internal…RowRanges)` (+ the `TransParquetFileReader` inherited form)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
