wgtmac commented on code in PR #3597:
URL: https://github.com/apache/parquet-java/pull/3597#discussion_r3519097750
##########
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetFileReader.java:
##########
@@ -1268,6 +1268,22 @@ public ColumnChunkPageReadStore readFilteredRowGroup(int
blockIndex, RowRanges r
return internalReadFilteredRowGroup(block, rowRanges,
getColumnIndexStore(blockIndex));
}
+ /**
+ * @param blockIndex the index of the requested block
+ * @param rowRanges the row ranges to be read from the requested block
+ * @return the PageReadStore which can provide PageReaders for each column
or null if there are no rows in this block
+ * @throws IOException if an error occurs while reading
+ * @throws IllegalArgumentException if the {@code blockIndex} is invalid or
the {@code rowRanges} is null
+ * @deprecated use {@link #readFilteredRowGroup(int, RowRanges)} with
+ * {@link org.apache.parquet.filter2.columnindex.RowRanges} instead.
This overload is retained
+ * for backward compatibility and will be removed in 2.0.
+ */
+ @Deprecated
+ public ColumnChunkPageReadStore readFilteredRowGroup(
Review Comment:
Shouldn't we keep and deprecate original `readFilteredRowGroup` with
internal RowRanges API and add a new one with the public RowRanges API?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
