peter-toth commented on code in PR #3597:
URL: https://github.com/apache/parquet-java/pull/3597#discussion_r3500489437
##########
parquet-column/src/main/java/org/apache/parquet/filter2/columnindex/RowRanges.java:
##########
@@ -316,4 +316,72 @@ public List<Range> getRanges() {
public String toString() {
return ranges.toString();
}
+
+ /**
Review Comment:
I looked at the released (1.17.0) surface: the only genuinely-public,
cross-package method exposing `RowRanges` is
`ParquetFileReader.readFilteredRowGroup(int, RowRanges)`.
`ParquetFileReader.getRowRanges(int)`, that returns `RowRanges` was only made
public on `master` (1.18.0).
Everything else is under `org.apache.parquet.internal.*`.
Is it ok if we preserve compatibility for just `readFilteredRowGroup(int,
RowRanges)` and treat the `internal.*` relocations as internal changes with no
compat guarantee?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
