steveloughran commented on code in PR #3562:
URL: https://github.com/apache/parquet-java/pull/3562#discussion_r3560395433
##########
parquet-variant/src/main/java/org/apache/parquet/variant/VariantJsonParser.java:
##########
@@ -37,7 +39,7 @@ public final class VariantJsonParser {
private static final JsonFactory JSON_FACTORY = JsonFactory.builder()
.streamReadConstraints(StreamReadConstraints.builder()
- .maxNestingDepth(500)
+ .maxNestingDepth(MAX_VARIANT_DEPTH)
Review Comment:
That original 500 was completely chosen without any data as a general
resilience number, the goal being "a malicious file can damage the stack of the
thread processing it, but not the rest of the process". I went with the same
number for the variant for consistency, and after a discussion in the mailing
list went to 1k.
we haven't shipped the json parser yet, so no need for a release note. I
will look at #3415 notes to see if we should update it though
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
