steveloughran commented on PR #3562: URL: https://github.com/apache/parquet-java/pull/3562#issuecomment-4982060322
...that last patch (04f79) fixes ImmutableMetadata too; it's adjacent code and tests. I reviewed all uses of readUnsigned() and made sure they're being range checked before (Math.toIntExact()) for the casting, with > 0 check for signing. having just checked, this can be done in exactly one opcode in arm assembler (`tst x0, #0xffffffff00000000`), so this java code with multiple reads and two chances to mispredict branches is woeful, but at least the normal branch will be to not fail. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
