steveloughran commented on PR #3562: URL: https://github.com/apache/parquet-java/pull/3562#issuecomment-4960163330
went through the other uses, seems good. The one area not covered in `VariantUtil.getMetadataMap(ByteBuffer)`. This is only used in the ImmutableMetadata(ByteBuffer) ctor, which is used in some parts of AvroVariantConverter. * ignore that, assume it'll be zero risk (risk: being wrong) * ignore that, deal with later (risk: forgetting. this is inevitable) * cover it too. I think I should cover it as well, just for completeness -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
