RussellSpitzer commented on code in PR #3397: URL: https://github.com/apache/parquet-java/pull/3397#discussion_r3960571730
########## parquet-column/src/main/java/org/apache/parquet/column/values/alp/AlpConfig.java: ########## @@ -0,0 +1,89 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.parquet.column.values.alp; + +import java.util.Objects; + +/** + * Immutable per-column ALP encoding configuration: whether ALP is enabled and the vector size + * (number of values per encoded vector) to use. Bundled together so a column carries a single + * cohesive ALP setting rather than several independent properties. + */ +public final class AlpConfig { + + /** Default values per encoded vector. */ + public static final int DEFAULT_VECTOR_SIZE = AlpConstants.DEFAULT_VECTOR_SIZE; + + /** ALP disabled, with the default vector size. */ + public static final AlpConfig DISABLED = new AlpConfig(false, DEFAULT_VECTOR_SIZE); + + private final boolean enabled; + private final int vectorSize; + + /** + * @param enabled whether ALP encoding is enabled + * @param vectorSize values per encoded vector; must be a power of 2 in the supported range + * @throws IllegalArgumentException if {@code vectorSize} is not a supported vector size + */ + public AlpConfig(boolean enabled, int vectorSize) { Review Comment: There probably shouldn't be an "enabled" as part of this config. Whether ALP is on or off is separate from how it is configured. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
