RussellSpitzer commented on code in PR #3397:
URL: https://github.com/apache/parquet-java/pull/3397#discussion_r3962456171
##########
parquet-column/src/main/java/org/apache/parquet/column/ParquetProperties.java:
##########
@@ -468,6 +504,8 @@ private Builder() {
DEFAULT_IS_BYTE_STREAM_SPLIT_ENABLED
? ByteStreamSplitMode.FLOATING_POINT
: ByteStreamSplitMode.NONE);
+ alp = ColumnProperty.<AlpConfig>builder()
Review Comment:
Silently overriding byteStreamSplitEnabled
We probably want a slightly more complicated logic here
If (bytestream && ALP) fail (can't use both)
... elif(bytestream) {
bystreamEnabled ...
} elif( alp) {
alpEnabled
}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
