RussellSpitzer commented on code in PR #3397:
URL: https://github.com/apache/parquet-java/pull/3397#discussion_r3962574774
##########
parquet-column/src/main/java/org/apache/parquet/column/ParquetProperties.java:
##########
@@ -585,6 +624,77 @@ public Builder withExtendedByteStreamSplitEncoding(boolean
enable) {
return this;
}
+ /**
+ * Set the full ALP configuration for FLOAT and DOUBLE columns.
+ *
+ * @param config the ALP configuration
+ * @return this builder for method chaining.
+ */
+ public Builder withAlp(AlpConfig config) {
Review Comment:
These APIs seem a bit over-specified for what we allow?
I feel like we have
withAlp(config) // sets ALP on everywhere
withAlp(columnPath, config) // set config on one column
withAlp() // Sets ALP on with default config
withAlp(columnPath) //sets alp as on for a single column
I'm not sure we need the ability to flip the encoding back off
Then I would make sure that none of this includes implementation details
(like config parameters) in the method names.
I would also consider whether we should fail if "ALP" is enabled on a non
float/double column
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
