steveloughran commented on PR #3562: URL: https://github.com/apache/parquet-java/pull/3562#issuecomment-6385485096
pushing up a PR with the javadoc comments of @laskoviymishka in. that leaves the fast single element array access use case of @wgtmac. 1. How common a use case is this? 2. should we think about not doing up front checking, but instead going to on demand. 3. what would be the negative consequences of a late check? what I do think matters is validating that the keys of an object are all in the metadata bytes; that is not needed for arrays BTW people who don't know should be aware that I am effectively not coding except occasionally at weekends to try and do some wrap up of security stuff, so doing an efficient redesign isn't going to happen; "cut this check" is about all you can expect. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
