Devdha commented on code in PR #3880:
URL: https://github.com/apache/parquet-java/pull/3880#discussion_r4413636932
##########
parquet-common/src/main/java/org/apache/parquet/hadoop/metadata/CompressionCodecName.java:
##########
@@ -27,7 +27,7 @@ public enum CompressionCodecName {
SNAPPY("org.apache.parquet.hadoop.codec.SnappyCodec",
CompressionCodec.SNAPPY, ".snappy"),
GZIP("org.apache.hadoop.io.compress.GzipCodec", CompressionCodec.GZIP,
".gz"),
LZO("com.hadoop.compression.lzo.LzoCodec", CompressionCodec.LZO, ".lzo"),
- BROTLI("org.apache.hadoop.io.compress.BrotliCodec", CompressionCodec.BROTLI,
".br"),
+ BROTLI("org.apache.parquet.hadoop.codec.BrotliCodec",
CompressionCodec.BROTLI, ".br"),
Review Comment:
Applied your suggested alias in 93054b410091165db03e1ad298efeb6250001ef9.
The legacy class name now maps to `BROTLI`, while `BROTLI` continues to resolve
to the new brotli4j-backed codec.
Added the five regression tests for legacy/current class names, other
codecs, unknown classes, and null. I confirmed that the legacy-name test fails
without the alias and passes with it.
Validation:
- `parquet-common`: all 337 tests passed.
- On JDK 17: `TestBrotliCodec` (11), the full `TestDirectCodecFactory` (15),
and `CodecConfigTest` (1) all passed.
- Repository-wide `spotless:check` passed.
The Hadoop test run used `-Denforcer.skip=true` for the pre-existing JUnit 4
imports in `TestFooterIntegrity`. The new GitHub Actions runs currently show
`action_required`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
