[
https://issues.apache.org/jira/browse/PHOENIX-4835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16571689#comment-16571689
]
Josh Elser commented on PHOENIX-4835:
-------------------------------------
{quote}We should move it to {{close()}} method instead
{quote}
Is this what you want? I can see that we want to push metrics when the
connection closes, but wouldn't we also want to push them during commit()? (log
metrics on commit() _and_ close()) My thinking is that we would benefit from
pushing them earlier (and this will help keep close() fast). Just a thought :)
> LoggingPhoenixConnection should log metrics upon connection close
> -----------------------------------------------------------------
>
> Key: PHOENIX-4835
> URL: https://issues.apache.org/jira/browse/PHOENIX-4835
> Project: Phoenix
> Issue Type: Improvement
> Reporter: Karan Mehta
> Priority: Major
> Attachments: PHOENIX-4835.4.x-HBase-1.4.001.patch
>
>
> {{LoggingPhoenixConnection}} currently logs metrics upon {{commit()}}, which
> may miss the logging of metrics sometimes if commit is never called. We
> should move it to {{close()}} method instead.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
