[
https://issues.apache.org/jira/browse/PHOENIX-4835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16583185#comment-16583185
]
ASF GitHub Bot commented on PHOENIX-4835:
-----------------------------------------
GitHub user karanmehta93 opened a pull request:
https://github.com/apache/phoenix/pull/328
PHOENIX-4835 LoggingPhoenixConnection should log metrics upon connect…
…ion close
@ankitsinghal I did some refactoring in tests and added new tests for the
scenario along with now logging metrics both on close and commit. Hence, a
quick look at PR would be helpful.
There is one more small pending problem, metrics won't be logged when
auto_commit is set to true. Will file a separate Jira for that.
FYI, Closed original PR since it had incorrect title.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/karanmehta93/phoenix 4.x-HBase-1.4
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/phoenix/pull/328.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #328
----
commit ed4f4ed7194d46432339167031831f3cf49feeb6
Author: Karan Mehta <karanmehta93@...>
Date: 2018-08-16T22:08:12Z
PHOENIX-4835 LoggingPhoenixConnection should log metrics upon connection
close
----
> LoggingPhoenixConnection should log metrics upon connection close
> -----------------------------------------------------------------
>
> Key: PHOENIX-4835
> URL: https://issues.apache.org/jira/browse/PHOENIX-4835
> Project: Phoenix
> Issue Type: Improvement
> Reporter: Karan Mehta
> Assignee: Karan Mehta
> Priority: Major
> Attachments: PHOENIX-4834.4.x-HBase-1.4.002.patch,
> PHOENIX-4835.4.x-HBase-1.4.001.patch
>
>
> {{LoggingPhoenixConnection}} currently logs metrics upon {{commit()}}, which
> may miss the logging of metrics sometimes if commit is never called. We
> should move it to {{close()}} method instead.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
