[
https://issues.apache.org/jira/browse/PHOENIX-4835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16578739#comment-16578739
]
Ankit Singhal commented on PHOENIX-4835:
----------------------------------------
Thanks [~karanmehta93] for checking out, if there will be no mutation metric
in the queue during the close, we should be ok.
bq. IMHO, logging on both commit and close makes sense.
+1 for logging during commit() and close() both, Just move super.close() in
finally block during close. Thanks.
{code:java}
try{
//logging
}finally{
super.close();
}{code}
> LoggingPhoenixConnection should log metrics upon connection close
> -----------------------------------------------------------------
>
> Key: PHOENIX-4835
> URL: https://issues.apache.org/jira/browse/PHOENIX-4835
> Project: Phoenix
> Issue Type: Improvement
> Reporter: Karan Mehta
> Priority: Major
> Attachments: PHOENIX-4835.4.x-HBase-1.4.001.patch
>
>
> {{LoggingPhoenixConnection}} currently logs metrics upon {{commit()}}, which
> may miss the logging of metrics sometimes if commit is never called. We
> should move it to {{close()}} method instead.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
