[ 
https://issues.apache.org/jira/browse/PHOENIX-4750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16576646#comment-16576646
 ] 

Josh Elser commented on PHOENIX-4750:
-------------------------------------

{quote}I thought about doing that for the other PQS ITs. Added an 
QueryServerTestUtil#startLocalHBaseCluster(String uniqueName) for those tests 
in v4. I opted to keep the new IT a bit simpler by not requiring a JUnit Rule.
{quote}
I dunno – what you have now to try to extract a unique name seems pretty 
(frankly) ugly compared to a JUnit {{TestName}} rule. Potentially error prone 
as well.

However, if you want to leave it to PHOENIX-4844, I won't object.

> Resolve server customizers and provide them to Avatica
> ------------------------------------------------------
>
>                 Key: PHOENIX-4750
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4750
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: Alex Araujo
>            Assignee: Alex Araujo
>            Priority: Major
>              Labels: queryserver
>             Fix For: 4.15.0, 4.14.1, 5.1.0
>
>         Attachments: PHOENIX-4750.patch, PHOENIX-4750.v2.patch, 
> PHOENIX-4750.v3.patch, PHOENIX-4750.v4.patch
>
>
> CALCITE-2284 allows finer grained customization of the underlying Avatica 
> HttpServer.
> Resolve server customizers on the PQS classpath and provide them to the 
> HttpServer builder.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to