[
https://issues.apache.org/jira/browse/PHOENIX-4835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16583272#comment-16583272
]
Hadoop QA commented on PHOENIX-4835:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12935947/PHOENIX-4835.4.x-HBase-1.4.002.patch
against 4.x-HBase-1.4 branch at commit
05edcd137c1940399ce9d679af2822889a3914bc.
ATTACHMENT ID: 12935947
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ assertEquals("There should have been read metrics only for one
table: " + tableName, 1, numTables);
+ void assertMutationMetrics(String tableName, int numRows, Map<String,
Map<MetricType, Long>> mutationMetrics) {
+ assertTrue("No mutation metrics present when there should have been",
mutationMetrics.size() > 0);
+
phoenixMetricsLog.logWriteMetricsfoForMutations(PhoenixRuntime.getWriteMetricInfoForMutationsSinceLastReset(conn));
+
phoenixMetricsLog.logReadMetricInfoForMutationsSinceLastReset(PhoenixRuntime.getReadMetricInfoForMutationsSinceLastReset(conn));
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.StatsEnabledSplitSystemCatalogIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1991//testReport/
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1991//console
This message is automatically generated.
> LoggingPhoenixConnection should log metrics upon connection close
> -----------------------------------------------------------------
>
> Key: PHOENIX-4835
> URL: https://issues.apache.org/jira/browse/PHOENIX-4835
> Project: Phoenix
> Issue Type: Improvement
> Reporter: Karan Mehta
> Assignee: Karan Mehta
> Priority: Major
> Attachments: PHOENIX-4835.4.x-HBase-1.4.001.patch,
> PHOENIX-4835.4.x-HBase-1.4.002.patch
>
>
> {{LoggingPhoenixConnection}} currently logs metrics upon {{commit()}}, which
> may miss the logging of metrics sometimes if commit is never called. We
> should move it to {{close()}} method instead.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
