Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/298#discussion_r211402317
  
    --- Diff: 
phoenix-core/src/it/java/org/apache/phoenix/end2end/join/HashJoinPersistentCacheIT.java
 ---
    @@ -0,0 +1,137 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.phoenix.end2end.join;
    +
    +import static org.apache.phoenix.util.TestUtil.TEST_PROPERTIES;
    +import static org.junit.Assert.assertEquals;
    +
    +import java.sql.Connection;
    +import java.sql.DriverManager;
    +import java.sql.ResultSet;
    +import java.util.Properties;
    +
    +import org.apache.phoenix.end2end.join.HashJoinCacheIT.InvalidateHashCache;
    +import org.apache.phoenix.util.PropertiesUtil;
    +import org.apache.phoenix.util.SchemaUtil;
    +import org.apache.phoenix.util.TestUtil;
    +import org.junit.Test;
    +
    +public class HashJoinPersistentCacheIT extends BaseJoinIT {
    +
    +    @Override
    +    protected String getTableName(Connection conn, String virtualName) 
throws Exception {
    +        String realName = super.getTableName(conn, virtualName);
    +        TestUtil.addCoprocessor(conn, 
SchemaUtil.normalizeFullTableName(realName), InvalidateHashCache.class);
    +        return realName;
    +    }
    +                
    +    @Test
    +    public void testPersistentCache() throws Exception {
    --- End diff --
    
    This is a very nice test!


---

Reply via email to