[GitHub] phoenix pull request #298: PHOENIX-4666 Persistent subquery cache for hash j...

[twdsilva]

Github user twdsilva commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/298#discussion_r211426819
  
    --- Diff: 
phoenix-core/src/main/java/org/apache/phoenix/iterate/TableResultIterator.java 
---
    @@ -194,13 +194,10 @@ public Tuple next() throws SQLException {
                                 if (retry <= 0) {
                                     throw e1;
                                 }
    +                            Long cacheId = 
((HashJoinCacheNotFoundException) e1).getCacheId();
                                 retry--;
                                 try {
    -                                Long cacheId = 
((HashJoinCacheNotFoundException) e1).getCacheId();
    -
    -                                ServerCache cache = caches == null ? null :
    --- End diff --
    
    Do we not need this null check any more?


---