Github user dbwong commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/298#discussion_r211430186
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/execute/HashJoinPlan.java ---
@@ -241,8 +251,35 @@ public TaskExecutionMetricsHolder
getTaskExecutionMetric() {
if (statement.getInnerSelectStatement() != null && postFilter !=
null) {
iterator = new FilterResultIterator(iterator, postFilter);
}
-
- return iterator;
+
+ if (hasSubPlansWithPersistentCache) {
+ return peekForPersistentCache(iterator, scanGrouper, scan);
+ } else {
+ return iterator;
+ }
+ }
+
+ private ResultIterator peekForPersistentCache(ResultIterator iterator,
ParallelScanGrouper scanGrouper, Scan scan) throws SQLException {
--- End diff --
Is there a test for this retry logic with the setDisablePersistenCache that
I'm missing? I don't see error path testing.
---
