[
https://issues.apache.org/jira/browse/PHOENIX-4731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16637551#comment-16637551
]
ASF GitHub Bot commented on PHOENIX-4731:
-----------------------------------------
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/360#discussion_r222480439
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/execute/PhoenixTxIndexMutationGenerator.java
---
@@ -313,7 +326,18 @@ public int compare(Cell o1, Cell o2) {
private void generateDeletes(PhoenixIndexMetaData indexMetaData,
Collection<Pair<Mutation, byte[]>> indexUpdates,
byte[] attribValue, TxTableState state) throws IOException {
- Iterable<IndexUpdate> deletes = codec.getIndexDeletes(state,
indexMetaData);
+ byte[] regionStartKey = this.regionStartKey;
--- End diff --
Just for my understanding, why do we now need the start and stop key to
generate the index deletes and upserts?
> Make running transactional unit tests for a given provider optional
> -------------------------------------------------------------------
>
> Key: PHOENIX-4731
> URL: https://issues.apache.org/jira/browse/PHOENIX-4731
> Project: Phoenix
> Issue Type: Improvement
> Reporter: James Taylor
> Assignee: James Taylor
> Priority: Major
> Fix For: 4.15.0
>
> Attachments: PHOENIX-4731-4.x-HBase-1.3.patch
>
>
> Different users may not be relying on transactions, or may only be relying on
> a single transaction provider. By default, we can run transactional tests
> across all providers, but we should have a way of disabling the running of a
> given provider.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
