[
https://issues.apache.org/jira/browse/PHOENIX-4731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16639608#comment-16639608
]
Hadoop QA commented on PHOENIX-4731:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12942515/PHOENIX-4731_v3-4.x-HBase-1.3.patch
against 4.x-HBase-1.3 branch at commit
4564fc57fe749afc29aa3ceeba703b5d6c89ae83.
ATTACHMENT ID: 12942515
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 17 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 release audit{color}. The applied patch generated 1 release
audit warnings (more than the master's current 0 warnings).
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ conn.createStatement().execute("ALTER TABLE " + baseTableName
+ " SET TRANSACTIONAL=true, TRANSACTION_PROVIDER='TEPHRA'");
+ return TestUtil.filterTxParamData(Arrays.asList(new Object[][] {
{"TEPHRA"}, {"OMID"}, {null} }), 0);
+ @Parameters(name =
"mutable={0},transactionProvider={1},isUserTableNamespaceMapped={2},columnEncoded={3}")
+ @Parameters(name =
"mutable={0},transactionProvider={1},isUserTableNamespaceMapped={2},columnEncoded={3}")
+ @Parameters(name =
"mutable={0},transactionProvider={1},isUserTableNamespaceMapped={2},columnEncoded={3}")
+ @Parameters(name =
"mutable={0},transactionProvider={1},isUserTableNamespaceMapped={2},columnEncoded={3}")
+ public synchronized PhoenixTransactionClient
initTransactionClient(Provider provider) throws SQLException {
+ optionBuilder.append(" TRANSACTIONAL=true,TRANSACTION_PROVIDER='"
+ transactionProvider + "'");
+ name =
"transactionProvider={0},mutable={1},localIndex={2},directApi={3},useSnapshot={4}")
+ list.add(new Object[] { transactionProvider,
mutable, localIndex, directApi, useSnapshot });
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.SkipScanAfterManualSplitIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.AlterMultiTenantTableWithViewsIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.AlterTableWithViewsIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.LocalIndexIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2077//testReport/
Release audit warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2077//artifact/patchprocess/patchReleaseAuditWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2077//console
This message is automatically generated.
> Make running transactional unit tests for a given provider optional
> -------------------------------------------------------------------
>
> Key: PHOENIX-4731
> URL: https://issues.apache.org/jira/browse/PHOENIX-4731
> Project: Phoenix
> Issue Type: Improvement
> Reporter: James Taylor
> Assignee: James Taylor
> Priority: Major
> Fix For: 4.15.0
>
> Attachments: PHOENIX-4731-4.x-HBase-1.3.patch,
> PHOENIX-4731_v2-4.x-HBase-1.3.patch, PHOENIX-4731_v3-4.x-HBase-1.3.patch
>
>
> Different users may not be relying on transactions, or may only be relying on
> a single transaction provider. By default, we can run transactional tests
> across all providers, but we should have a way of disabling the running of a
> given provider.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
