[ 
https://issues.apache.org/jira/browse/PHOENIX-4731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16637552#comment-16637552
 ] 

ASF GitHub Bot commented on PHOENIX-4731:
-----------------------------------------

Github user twdsilva commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/360#discussion_r222480675
  
    --- Diff: 
phoenix-core/src/main/java/org/apache/phoenix/index/IndexMaintainer.java ---
    @@ -184,9 +184,24 @@ public boolean apply(PTable index) {
          */
         public static void serialize(PTable dataTable, ImmutableBytesWritable 
ptr, PhoenixConnection connection) {
             List<PTable> indexes = dataTable.getIndexes();
    -        serialize(dataTable, ptr, indexes, connection);
    +        serializeServerMaintainedIndexes(dataTable, ptr, indexes, 
connection);
         }
     
    +    public static void serializeServerMaintainedIndexes(PTable dataTable, 
ImmutableBytesWritable ptr,
    +            List<PTable> indexes, PhoenixConnection connection) {
    +        Iterator<PTable> indexesItr = Collections.emptyListIterator();
    +        boolean onlyLocalIndexes = dataTable.isImmutableRows() || 
dataTable.isTransactional();
    +        if (onlyLocalIndexes) {
    --- End diff --
    
    Do we do anything special for transactional tables with local indexes?


> Make running transactional unit tests for a given provider optional
> -------------------------------------------------------------------
>
>                 Key: PHOENIX-4731
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4731
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: James Taylor
>            Assignee: James Taylor
>            Priority: Major
>             Fix For: 4.15.0
>
>         Attachments: PHOENIX-4731-4.x-HBase-1.3.patch
>
>
> Different users may not be relying on transactions, or may only be relying on 
> a single transaction provider. By default, we can run transactional tests 
> across all providers, but we should have a way of disabling the running of a 
> given provider.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to