[ 
https://issues.apache.org/jira/browse/PHOENIX-4891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16662645#comment-16662645
 ] 

Hadoop QA commented on PHOENIX-4891:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12945442/PHOENIX-4891.patch
  against master branch at commit 0c28ea2856aa0798953b790c002644969a36ae5e.
  ATTACHMENT ID: 12945442

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:red}-1 release audit{color}.  The applied patch generated 1 release 
audit warnings (more than the master's current 0 warnings).

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines 
longer than 100:
    +    private static final int MODIFIED_UPDATE_CACHE_FREQUENCY_VIEWS = 
INITIAL_UPDATE_CACHE_FREQUENCY_VIEWS + 300;
+        String globalIndexName = createIndexTable(conn, tableName, 
PTable.IndexType.GLOBAL).getSecond();
+            tablesToCheck.add(createIndexTable(conn, tableName, 
PTable.IndexType.LOCAL).getSecond());
+            tablesToCheck.add(createIndexTable(conn, tableName, 
PTable.IndexType.GLOBAL).getSecond());
+        String newGlobalIndex = createIndexTable(conn, tableName, 
PTable.IndexType.GLOBAL).getSecond();
+            tablesToCheck.add(createIndexTable(conn, tableName, 
PTable.IndexType.LOCAL).getSecond());
+            tablesToCheck.add(createIndexTable(conn, tableName, 
PTable.IndexType.GLOBAL).getSecond());
+        String globalIndexName = createIndexTable(conn, tableName, 
PTable.IndexType.GLOBAL).getSecond();
+            createdTables.add(createIndexTable(conn, baseTableName, 
PTable.IndexType.GLOBAL).getSecond());
+            createdTables.add(createIndexTable(conn, baseTableName, 
PTable.IndexType.LOCAL).getSecond());

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
                       org.apache.phoenix.jdbc.SecureUserConnectionsTest

Test results: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2105//testReport/
Release audit warnings: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2105//artifact/patchprocess/patchReleaseAuditWarnings.txt
Console output: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2105//console

This message is automatically generated.

> An index should inherit UPDATE_CACHE_FREQUENCY setting from parent table
> ------------------------------------------------------------------------
>
>                 Key: PHOENIX-4891
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4891
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Lars Hofhansl
>            Assignee: Chinmay Kulkarni
>            Priority: Minor
>         Attachments: PHOENIX-4891.patch
>
>
> I tried:
> # creating a table with UPDATE_CACHE_FREQUENCE > 0, then creating a local 
> index on the table.
> # creating a table, then creating the local index, then altering the table 
> setting UPDATE_CACHE_FREQUENCY to > 0
> In both cases the local index did not inherit the setting, verified both by 
> looking at SYSTEM.CATALOG, as well by behavior.
> Update: This also happens for a global index.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to