[ 
https://issues.apache.org/jira/browse/PHOENIX-4891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16661618#comment-16661618
 ] 

ASF GitHub Bot commented on PHOENIX-4891:
-----------------------------------------

Github user twdsilva commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/363#discussion_r227621900
  
    --- Diff: 
phoenix-core/src/it/java/org/apache/phoenix/end2end/PropertiesInSyncIT.java ---
    @@ -402,16 +486,17 @@ private String createBaseTableWithProps(Connection 
conn) throws SQLException {
          * @param baseTableName Name of the HBase base table on which to 
create an index
          * @param indexType LOCAL, GLOBAL or if we pass in null as the 
indexType,
          *                 we create a view and an index on that view for the 
given base table
    +     * @param returnLocalIndex if true, when creating a local index, 
return the local index name
    +     *                         of the base table name instead of the 
physical base table name
          * @return The physical HBase table corresponding to the index created
    --- End diff --
    
    This doesn't always return the physical HBase table that stores the index 
being created right? Might be a cleaner if you return a pair of the index name 
and the index physical table name.


> An index should inherit UPDATE_CACHE_FREQUENCY setting from parent table
> ------------------------------------------------------------------------
>
>                 Key: PHOENIX-4891
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4891
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Lars Hofhansl
>            Assignee: Chinmay Kulkarni
>            Priority: Minor
>
> I tried:
> # creating a table with UPDATE_CACHE_FREQUENCE > 0, then creating a local 
> index on the table.
> # creating a table, then creating the local index, then altering the table 
> setting UPDATE_CACHE_FREQUENCY to > 0
> In both cases the local index did not inherit the setting, verified both by 
> looking at SYSTEM.CATALOG, as well by behavior.
> Update: This also happens for a global index.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to