[
https://issues.apache.org/jira/browse/PHOENIX-5131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16792244#comment-16792244
]
Chinmay Kulkarni commented on PHOENIX-5131:
-------------------------------------------
[~abhishek.chouhan] had a brief look and apart from Vincent's comments had a
few nits:
1) In the tests, instead of asserting the exception message, can we assert on
SQLExceptionCode? In case the message changes, it can lead to misleading test
failures.
2) Wherever we have queue implementations that don't increment the size since
they ultimately call offer (wherein we do increment the size), can we add a
comment to indicate this, to avoid future confusions.
Thanks!
> Make spilling to disk for order/group by configurable
> -----------------------------------------------------
>
> Key: PHOENIX-5131
> URL: https://issues.apache.org/jira/browse/PHOENIX-5131
> Project: Phoenix
> Issue Type: Improvement
> Reporter: Abhishek Singh Chouhan
> Assignee: Abhishek Singh Chouhan
> Priority: Major
> Fix For: 4.15.0, 5.1.0
>
> Attachments: PHOENIX-5131-master-v2.patch,
> PHOENIX-5131-master-v2.patch, PHOENIX-5131-master-v3.patch,
> PHOENIX-5131-master-v4.patch, PHOENIX-5131-master.patch,
> PHOENIX-5131-master.patch
>
>
> We've observed that large queries, doing order/group by leading to issues on
> the regionserver (crashes/long gc pauses/file handler exhaustion etc.). We
> should make spilling to disk configurable and in case its disabled, fail the
> query once it hits the spilling limit on any of the region servers. Also make
> spooling threshold server-side property only to prevent clients from
> controlling memory allocation on the rs side.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
