[ 
https://issues.apache.org/jira/browse/PHOENIX-5131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16793102#comment-16793102
 ] 

Hudson commented on PHOENIX-5131:
---------------------------------

FAILURE: Integrated in Jenkins build PreCommit-PHOENIX-Build #2426 (See 
[https://builds.apache.org/job/PreCommit-PHOENIX-Build/2426/])
PHOENIX-5131 Make spilling to disk for order/group by configurable 
(chinmayskulkarni: rev 05b99018a77805cd92411c26bd4147e62cbf7281)
* (edit) 
phoenix-core/src/main/java/org/apache/phoenix/execute/SortMergeJoinPlan.java
* (edit) 
phoenix-core/src/main/java/org/apache/phoenix/iterate/BufferedSortedQueue.java
* (edit) 
phoenix-core/src/test/java/org/apache/phoenix/util/MetaDataUtilTest.java
* (edit) 
phoenix-core/src/main/java/org/apache/phoenix/iterate/OrderedResultIterator.java
* (edit) 
phoenix-core/src/main/java/org/apache/phoenix/execute/ClientAggregatePlan.java
* (edit) 
phoenix-core/src/main/java/org/apache/phoenix/execute/ClientScanPlan.java
* (edit) 
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataProtocol.java
* (edit) 
phoenix-core/src/main/java/org/apache/phoenix/iterate/OrderedAggregatingResultIterator.java
* (add) 
phoenix-core/src/main/java/org/apache/phoenix/iterate/SizeBoundQueue.java
* (edit) 
phoenix-core/src/it/java/org/apache/phoenix/end2end/OrderByWithSpillingIT.java
* (edit) 
phoenix-core/src/test/java/org/apache/phoenix/iterate/OrderedResultIteratorTest.java
* (edit) 
phoenix-core/src/test/java/org/apache/phoenix/query/QueryServicesTestImpl.java
* (edit) 
phoenix-core/src/main/java/org/apache/phoenix/query/QueryServicesOptions.java
* (edit) 
phoenix-core/src/main/java/org/apache/phoenix/hbase/index/util/VersionUtil.java
* (add) 
phoenix-core/src/it/java/org/apache/phoenix/end2end/OrderByWithServerMemoryLimitIT.java
* (edit) 
phoenix-core/src/main/java/org/apache/phoenix/iterate/NonAggregateRegionScannerFactory.java
* (add) 
phoenix-core/src/it/java/org/apache/phoenix/end2end/join/SortMergeJoinNoSpoolingIT.java
* (edit) 
phoenix-core/src/main/java/org/apache/phoenix/execute/AggregatePlan.java
* (edit) phoenix-core/src/main/java/org/apache/phoenix/query/QueryServices.java
* (add) 
phoenix-core/src/it/java/org/apache/phoenix/end2end/OrderByWithServerClientSpoolingDisabledIT.java
* (edit) 
phoenix-core/src/it/java/org/apache/phoenix/end2end/SpooledTmpFileDeleteIT.java
* (edit) 
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/ScanRegionObserver.java
* (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/OrderByIT.java
* (add) phoenix-core/src/main/java/org/apache/phoenix/iterate/PhoenixQueues.java
* (edit) 
phoenix-core/src/main/java/org/apache/phoenix/iterate/BufferedQueue.java
* (edit) 
phoenix-core/src/main/java/org/apache/phoenix/iterate/SpoolingResultIterator.java
* (edit) phoenix-core/src/main/java/org/apache/phoenix/execute/ScanPlan.java
* (add) 
phoenix-core/src/main/java/org/apache/phoenix/iterate/SizeAwareQueue.java
* (add) 
phoenix-core/src/main/java/org/apache/phoenix/iterate/BufferedTupleQueue.java


> Make spilling to disk for order/group by configurable
> -----------------------------------------------------
>
>                 Key: PHOENIX-5131
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5131
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: Abhishek Singh Chouhan
>            Assignee: Abhishek Singh Chouhan
>            Priority: Major
>             Fix For: 4.15.0, 5.1.0
>
>         Attachments: PHOENIX-5131-4.x-HBase-1.2.patch, 
> PHOENIX-5131-4.x-HBase-1.3.patch, PHOENIX-5131-4.x-HBase-1.4.patch, 
> PHOENIX-5131-master-v2.patch, PHOENIX-5131-master-v2.patch, 
> PHOENIX-5131-master-v3.patch, PHOENIX-5131-master-v4.patch, 
> PHOENIX-5131-master.patch, PHOENIX-5131-master.patch
>
>
> We've observed that large queries, doing order/group by leading to issues on 
> the regionserver (crashes/long gc pauses/file handler exhaustion etc.). We 
> should make spilling to disk configurable and in case its disabled, fail the 
> query once it hits the spilling limit on any of the region servers. Also make 
> spooling threshold server-side property only to prevent clients from 
> controlling memory allocation on the rs side.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to