[
https://issues.apache.org/jira/browse/PHOENIX-5131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16792369#comment-16792369
]
Hadoop QA commented on PHOENIX-5131:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12962424/PHOENIX-5131-4.x-HBase-1.4.patch
against 4.x-HBase-1.4 branch at commit
6e3cb3139970d7ec856dc563eadba776d42bbbde.
ATTACHMENT ID: 12962424
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 9 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ "SELECT /*+ USE_SORT_MERGE_JOIN*/ item.\"item_id\",
item.name, supp.\"supplier_id\", supp.name FROM "
+ + " supp ON item.\"supplier_id\" =
supp.\"supplier_id\" ORDER BY \"item_id\"";
+ && clientVersion <
MetaDataProtocol.MIN_5_x_DISABLE_SERVER_SPOOL_THRESHOLD)
+ && clientVersion <
MetaDataProtocol.MIN_4_x_DISABLE_SERVER_SPOOL_THRESHOLD);
+ List<OrderByExpression> orderByExpressions, boolean
spoolingEnabled, long thresholdBytes,
+ SpoolingResultIterator(SpoolingMetricsHolder sMetrics, MemoryMetricsHolder
mMetrics, ResultIterator scanner, MemoryManager mm, final long thresholdBytes,
final long maxSpoolToDisk, final String spoolDirectory) throws SQLException {
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.trace.PhoenixTracingEndToEndIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2422//testReport/
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2422//console
This message is automatically generated.
> Make spilling to disk for order/group by configurable
> -----------------------------------------------------
>
> Key: PHOENIX-5131
> URL: https://issues.apache.org/jira/browse/PHOENIX-5131
> Project: Phoenix
> Issue Type: Improvement
> Reporter: Abhishek Singh Chouhan
> Assignee: Abhishek Singh Chouhan
> Priority: Major
> Fix For: 4.15.0, 5.1.0
>
> Attachments: PHOENIX-5131-4.x-HBase-1.4.patch,
> PHOENIX-5131-master-v2.patch, PHOENIX-5131-master-v2.patch,
> PHOENIX-5131-master-v3.patch, PHOENIX-5131-master-v4.patch,
> PHOENIX-5131-master.patch, PHOENIX-5131-master.patch
>
>
> We've observed that large queries, doing order/group by leading to issues on
> the regionserver (crashes/long gc pauses/file handler exhaustion etc.). We
> should make spilling to disk configurable and in case its disabled, fail the
> query once it hits the spilling limit on any of the region servers. Also make
> spooling threshold server-side property only to prevent clients from
> controlling memory allocation on the rs side.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
