[
https://issues.apache.org/jira/browse/PHOENIX-5169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16795126#comment-16795126
]
Josh Elser commented on PHOENIX-5169:
-------------------------------------
[~Jaanai], I'm a bit confused at your patch still. What you've added to
PhoenixStatement is already being done inside {{QueryLogger.getInstance()}}.
>From your stacktraces, it seems like you're actually concerned by the
>performance of {{QueryLoggerUtil.logInitialDetails}}. I think you should
>update just that method to bail out quickly if the query log level is OFF.
> Query logger is still initialized for each query when the log level is off
> --------------------------------------------------------------------------
>
> Key: PHOENIX-5169
> URL: https://issues.apache.org/jira/browse/PHOENIX-5169
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 5.0.0
> Reporter: jaanai
> Assignee: jaanai
> Priority: Major
> Fix For: 5.1
>
> Attachments: PHOENIX-5169-master-v2.patch,
> PHOENIX-5169-master-v3.patch, PHOENIX-5169-master.patch,
> image-2019-02-28-10-05-00-518.png
>
>
> we will still invoke createQueryLogger in PhoenixStatement for each query
> when query logger level is OFF, which has significant throughput impacts
> under multiple threads.
> The below is jstack with the concurrent query:
> !https://gw.alicdn.com/tfscom/TB1HC3bI4TpK1RjSZFMXXbG_VXa.png|width=500,height=400!
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
