[
https://issues.apache.org/jira/browse/PHOENIX-5169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16795177#comment-16795177
]
Hadoop QA commented on PHOENIX-5169:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12962805/PHOENIX-5169-master-v3.patch
against master branch at commit dd8789b473fd8f0c35b0d5014f5c793fffa255e3.
ATTACHMENT ID: 12962805
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ conn.createStatement().executeUpdate("delete from " +
SYSTEM_CATALOG_SCHEMA + ".\"" + SYSTEM_LOG_TABLE + "\"");
+ String logQuery = "SELECT count(*) FROM " + SYSTEM_CATALOG_SCHEMA +
".\"" + SYSTEM_LOG_TABLE + "\"";
+ QueryLoggerUtil.logInitialDetails(queryLogger,
connection.getTenantId(), connection.getQueryServices(), sql, getParameters());
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.TableDDLPermissionsIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.MutableIndexSplitReverseScanIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.ConcurrentMutationsIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.ChangePermissionsIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.MutableIndexSplitForwardScanIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2440//testReport/
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2440//console
This message is automatically generated.
> Query logger is still initialized for each query when the log level is off
> --------------------------------------------------------------------------
>
> Key: PHOENIX-5169
> URL: https://issues.apache.org/jira/browse/PHOENIX-5169
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 5.0.0
> Reporter: jaanai
> Assignee: jaanai
> Priority: Major
> Fix For: 5.1
>
> Attachments: PHOENIX-5169-master-v2.patch,
> PHOENIX-5169-master-v3.patch, PHOENIX-5169-master.patch,
> image-2019-02-28-10-05-00-518.png
>
>
> we will still invoke createQueryLogger in PhoenixStatement for each query
> when query logger level is OFF, which has significant throughput impacts
> under multiple threads.
> The below is jstack with the concurrent query:
> !https://gw.alicdn.com/tfscom/TB1HC3bI4TpK1RjSZFMXXbG_VXa.png|width=500,height=400!
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
