[
https://issues.apache.org/jira/browse/PHOENIX-5169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16800727#comment-16800727
]
Josh Elser commented on PHOENIX-5169:
-------------------------------------
Thanks, didn't get a notification that you uploaded a new patch. V3 has what I
was thinking.
{code:java}
+ if (connection.getLogLevel() != LogLevel.OFF) {{code}
One suggestion, it's more of a nit, but I think it would be cleaner if you did
something liek:
{code:java}
if (connection.getLogLevel() == LogLevel.OFF) {
return QueryLogger.NO_OP_INSTANCE;
}
...
return queryLogger;{code}
This would remove a big indented chunk :). OK either way if you want to commit
v3 or address this comment and then commit :)
> Query logger is still initialized for each query when the log level is off
> --------------------------------------------------------------------------
>
> Key: PHOENIX-5169
> URL: https://issues.apache.org/jira/browse/PHOENIX-5169
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 5.0.0
> Reporter: jaanai
> Assignee: jaanai
> Priority: Major
> Fix For: 5.1
>
> Attachments: PHOENIX-5169-master-v2.patch,
> PHOENIX-5169-master-v3.patch, PHOENIX-5169-master.patch,
> image-2019-02-28-10-05-00-518.png
>
>
> we will still invoke createQueryLogger in PhoenixStatement for each query
> when query logger level is OFF, which has significant throughput impacts
> under multiple threads.
> The below is jstack with the concurrent query:
> !https://gw.alicdn.com/tfscom/TB1HC3bI4TpK1RjSZFMXXbG_VXa.png|width=500,height=400!
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
