ChinmaySKulkarni commented on a change in pull request #494: PHOENIX-5262 Wrong
Result on Salted table with Varbinary PK
URL: https://github.com/apache/phoenix/pull/494#discussion_r279581668
##########
File path: phoenix-core/src/main/java/org/apache/phoenix/util/ScanUtil.java
##########
@@ -448,7 +448,7 @@ public static int setKey(RowKeySchema schema,
List<List<KeyRange>> slots, int[]
key[offset++] = sepByte;
// Set lastInclusiveUpperSingleKey back to false if this is
the last pk column
// as we don't want to increment the null byte in this case
- lastInclusiveUpperSingleKey &= i < schema.getMaxFields()-1;
+ lastInclusiveUpperSingleKey &= (fieldIndex + slotSpan[i]) <
schema.getMaxFields()-1;
Review comment:
Can you add a short explanation above this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
