ChinmaySKulkarni commented on a change in pull request #494: PHOENIX-5262 Wrong
Result on Salted table with Varbinary PK
URL: https://github.com/apache/phoenix/pull/494#discussion_r279581977
##########
File path:
phoenix-core/src/test/java/org/apache/phoenix/compile/WhereCompilerTest.java
##########
@@ -183,7 +183,7 @@ public void testSingleFixedFullPkSalted() throws
SQLException {
@Test
public void testSingleVariableFullPkSalted() throws SQLException {
PhoenixConnection pconn = DriverManager.getConnection(getUrl(),
PropertiesUtil.deepCopy(TEST_PROPERTIES)).unwrap(PhoenixConnection.class);
- pconn.createStatement().execute("CREATE TABLE t (k varchar primary
key, v varchar) SALT_BUCKETS=20");
+ pconn.createStatement().execute("CREATE TABLE t (k varchar(10) primary
key, v varchar) SALT_BUCKETS=20");
Review comment:
Looks like this issue would exist for any variable-length field and not just
varbinary. Can you update the JIRA subject and description accordingly?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
